chore: use cometbft-db #2536
chore: use cometbft-db #2536
Conversation
gartnera
added
no-changelog
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWalkthroughThe recent updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GoModule
participant Dependencies
User->>GoModule: Initiate Update
GoModule->>Dependencies: Check for Latest Versions
Dependencies->>GoModule: Return Updated Versions
GoModule->>User: Update Complete
This sequence diagram illustrates the interaction between the user, the Go module, and its dependencies during the update process, showcasing the flow of initiating an update and receiving the latest versions. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
gartnera
force-pushed
the
use-cometbft-db
branch
from
1d20824 to
12672b6
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (1)
- go.mod (10 hunks)
Additional comments not posted (10)
go.mod (10)
3-3: Approved: Go version update.The update from
go 1.22togo 1.22.2is a minor version upgrade that includes important bug fixes and performance improvements.
5-5: Approved: Toolchain version update.The update from
toolchain go1.22totoolchain go1.22.5is a minor version upgrade that includes important bug fixes and performance improvements.
21-21: Approved: Dependency update forgithub.com/spf13/cobra.The update from
v1.7.0tov1.8.0likely includes new features, bug fixes, and performance improvements.
23-23: Approved: Dependency update forgithub.com/stretchr/testify.The update from
v1.8.4tov1.9.0likely includes new features, bug fixes, and performance improvements.
63-63: Approved: Dependency update forgithub.com/cockroachdb/errors.The update from
v1.10.0tov1.11.1likely includes new features, bug fixes, and performance improvements.
314-314: Approved: Dependency update forgithub.com/stretchr/objx.The update from
v0.5.1tov0.5.2likely includes bug fixes and performance improvements.
334-335: Approved: Dependency updates forgolang.org/x/syncandgolang.org/x/sys.The updates from
v0.5.0tov0.6.0forgolang.org/x/syncand fromv0.16.0tov0.18.0forgolang.org/x/syslikely include bug fixes and performance improvements.
94-94: Approved: Major version update forgithub.com/dgraph-io/badger.The update from
v2.2007.4tov4.2.0is a significant version upgrade. Ensure thorough testing to verify compatibility and stability.Verification successful
Approved: Major version update for
github.com/dgraph-io/badger.The update from
v2.2007.4tov4.2.0is a significant version upgrade. Thebadgerpackage is not directly used in the codebase, suggesting it is an indirect dependency. Ensure thorough testing to verify compatibility and stability with dependencies that might usebadgerindirectly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `github.com/dgraph-io/badger` to ensure compatibility with the major version upgrade. # Test: Search for the dependency usage. Expect: No breaking changes. rg --type go 'badger'Length of output: 21
Script:
#!/bin/bash # Description: Verify all usages of `github.com/dgraph-io/badger` to ensure compatibility with the major version upgrade. # Search for any import statements of the badger package. rg --type go 'import.*badger' -A 5 # Search for any usage of the badger package in the codebase. rg --type go 'badger\.' -A 5Length of output: 67
65-65: Approved: Major version update forgithub.com/cometbft/cometbft-db.The update from
v0.8.0tov0.12.0is a significant version upgrade. Ensure thorough testing to verify compatibility and stability.Verification successful
Approved: Major version update for
github.com/cometbft/cometbft-db.The update from
v0.8.0tov0.12.0is a significant version upgrade. The extracted usages ofcometbft-dbacross various files primarily involve initializing databases and memory stores. These usages appear consistent with typical patterns for database interactions and do not immediately indicate breaking changes.However, due to the extent of the version upgrade, it is crucial to conduct thorough testing to ensure compatibility and stability.
- Files to verify:
x/observer/client/querytests/cli_test.gox/crosschain/client/querytests/cli_test.gotestutil/simapp/simapp.gotestutil/keeper/fungible.gotestutil/keeper/observer.gotestutil/keeper/ibccrosschain.gotestutil/keeper/keeper.gotestutil/keeper/lightclient.gotestutil/keeper/emissions.gotestutil/keeper/crosschain.gotestutil/keeper/authority.goserver/start.gorpc/backend/tracing_test.gorpc/backend/tx_info_test.gorpc/backend/backend_suite_test.gocmd/zetacored/root.goapp/app.goEnsure thorough testing to verify compatibility and stability.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all usages of `github.com/cometbft/cometbft-db` to ensure compatibility with the major version upgrade. # Test: Search for the dependency usage. Expect: No breaking changes. rg --type go 'cometbft-db'Length of output: 1183
Script:
#!/bin/bash # Description: Extract and review usages of `github.com/cometbft/cometbft-db` in the identified files to ensure compatibility with the new version. # Define the files to be checked files=( "x/observer/client/querytests/cli_test.go" "x/crosschain/client/querytests/cli_test.go" "testutil/simapp/simapp.go" "testutil/keeper/fungible.go" "testutil/keeper/observer.go" "testutil/keeper/ibccrosschain.go" "testutil/keeper/keeper.go" "testutil/keeper/lightclient.go" "testutil/keeper/emissions.go" "testutil/keeper/crosschain.go" "testutil/keeper/authority.go" "server/start.go" "rpc/backend/tracing_test.go" "rpc/backend/tx_info_test.go" "rpc/backend/backend_suite_test.go" "cmd/zetacored/root.go" "app/app.go" ) # Loop through each file and extract the lines where `cometbft-db` is used for file in "${files[@]}"; do echo "File: $file" rg 'cometbft-db' "$file" -A 5 -B 5 echo "-----------------------------------" doneLength of output: 10094
Script:
#!/bin/bash # Description: Extract specific usages of `github.com/cometbft/cometbft-db` within the identified files to identify potential compatibility issues. # Define the files to be checked files=( "x/observer/client/querytests/cli_test.go" "x/crosschain/client/querytests/cli_test.go" "testutil/simapp/simapp.go" "testutil/keeper/fungible.go" "testutil/keeper/observer.go" "testutil/keeper/ibccrosschain.go" "testutil/keeper/keeper.go" "testutil/keeper/lightclient.go" "testutil/keeper/emissions.go" "testutil/keeper/crosschain.go" "testutil/keeper/authority.go" "server/start.go" "rpc/backend/tracing_test.go" "rpc/backend/tx_info_test.go" "rpc/backend/backend_suite_test.go" "cmd/zetacored/root.go" "app/app.go" ) # Loop through each file and extract the lines where `cometbft-db` is used for file in "${files[@]}"; do echo "File: $file" rg 'tmdb|dbm' "$file" -A 5 -B 5 echo "-----------------------------------" doneLength of output: 24319
132-132: Approved: Alpha version update forgo.etcd.io/bbolt.The update from
v1.3.7tov1.4.0-alpha.0.0.20240404170359-43604f3112c5includes an alpha version. Ensure thorough testing to verify compatibility and stability.
There was a problem hiding this comment.
- Is it okay that in cosmos repo it's still marked as experimental?
- Can you somehow ensure that it would run as usual with some db state from current
main? (e.g. run a localnet, then checkout to this branch)
// PebbleDBDBBackend represents pebble (uses github.com/cockroachdb/pebble)
// - EXPERIMENTAL
// - use pebbledb build tag (go build -tags pebbledb)
PebbleDBBackend BackendType = "pebbledb"Pre-approved.
It's approximately the same code we're using today. It's just upstreamed.
That's what the UPGRADE_TESTS does. I will also test with a state import. |
gartnera
added
the
UPGRADE_IMPORT_MAINNET_TESTS
gartnera
force-pushed
the
use-cometbft-db
branch
from
12672b6 to
de3c34e
Compare
gartnera
force-pushed
the
use-cometbft-db
branch
from
de3c34e to
5bfd111
Compare
Description
pebbledb is now upstreamed, we can stop using the fork.
CHANGELOG
Update: there seems to be some concern about the panic during an upgrade that we need to think about.
Update: I think failures are unrelated, see #2544
Update: test failures still seem unrelated, see #2596
Summary by CodeRabbit
New Features
Bug Fixes
Chores